mengw15 opened a new pull request, #8589:
URL: https://github.com/apache/texera/pull/8589

   ### What changes were proposed in this PR?
   
   Two follow-ups to the warehouse picker (#8551), both about the picker 
sitting next to the computing-unit one without matching it.
   
   - **The run button's label overflowed.** `#run-button` is a fixed 140px, 
which fits `Empty Workflow` with about a pixel to spare; `Create Warehouse` ran 
roughly 13px past it and spilled over the execution timer. The label is now 
`Warehouse` — the same word the picker's own empty state already shows, 
mirroring how the computing-unit flow repeats `Connect` in both places — and 
the button keeps its fixed width, so nothing else on the toolbar moves.
   - **The trigger ellipsises the warehouse name at 220px with no way to read 
it.** Its tooltip now carries the full name alongside what the picker is for — 
one tooltip on the button, rather than a second one on the name nested inside 
the first — and it drops a stray `margin-right` the computing-unit trigger does 
not have.
   
   Flag off (the default): the picker never renders and the run button is 
untouched.
   
   ### Any related issues, documentation, discussions?
   
   Follow-up to #8551. Part of #6870. The remaining divergences are on the 
computing-unit side and are tracked separately in #8587; a warehouse status 
badge needs a backend signal first (#8588).
   
   ### How was this PR tested?
   
   - Label widths measured in a browser against the button's real clipping 
width (140px minus padding, border and icon leaves ~106px for text) across the 
font stack's macOS, Windows and Linux faces: `Warehouse` 72px, `Create 
Warehouse` 119px, and main's own `Empty Workflow`/`Invalid Workflow` 105px.
   - Two Vitest specs updated/added (run-button label, trigger tooltip); the 
workspace suite passes in full: 3323 tests.
   - Failure paths verified rather than assumed: the label and the tooltip's 
name were each reverted on purpose and the suite confirmed to fail for the 
expected reason before being restored.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-5, claude-fable-5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to