mengw15 commented on PR #8443: URL: https://github.com/apache/texera/pull/8443#issuecomment-5650600877
Superseded by #7800, which repairs the same four `Random` sites in this file along with the two other spec defects from #7799. #8150 turned out to be a narrower re-file of one item already covered there — the duplicate issue is on our side, not yours. One note worth recording: #7800 creates a fresh `Random(Seed)` at each use site rather than sharing one instance-level generator. `testJoin` is called by most of the 15 tests, so with a shared generator each test's values depend on how many draws ran before it — two identical full-suite runs match, but `testOnly *IntervalOpExecSpec -- -z "1k"` still gets different inputs than the full run, which is the reproducibility case #8150 was about. Closing in favour of #7800. Thanks for the fix and for the before/after coverage runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
