yangzhang75 commented on code in PR #8516:
URL: https://github.com/apache/texera/pull/8516#discussion_r3994460105
##########
frontend/src/app/common/type/workflow.ts:
##########
@@ -67,13 +67,16 @@ export interface FormBindingConfig {
};
/** Array order is display order; the author reorders by dragging. */
fields: FormFieldBinding[];
- /** View-result operators whose results are also shown under the workflow
after a run, on top of
- * the final step's result, which always shows. */
- resultOperatorIds: string[];
+ /** Which steps' results show under the workflow after a run, for everyone.
Absent until the author
+ * chooses: then every final (terminal) step shows, as on the canvas. Once
set it is exhaustive:
+ * exactly these steps show, and [] means none. One list, so nothing can
contradict it; the cost is
+ * that a step which becomes final after the author has chosen does not
appear by itself. When
+ * displayed it is kept to steps that still have a result on the canvas. */
+ shownResultIds?: string[];
Review Comment:
No persisted workflow carries either field, so there is nothing to migrate:
`form-view-enabled = false` on main (gui.conf:89), the Form View page is the
only writer of `formBinding` (setFormBinding is reached only through
FormBindingService there; hydrateFormBinding and getWorkflowContent re-emit
what was loaded, and the backend only carries the content through), and that
page redirects to the canvas while the flag is off. That is the zero-cost
window mengw15 pointed at in the PR comment, which is why this is a rename
rather than a migration; #8456 is what turns the flag on. A stale key in a
developer database is ignored and the form falls back to the terminal default.
Leaving this open in case I have missed a writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
