mengw15 commented on PR #8516: URL: https://github.com/apache/texera/pull/8516#issuecomment-5641775155
Before this merges — the only zero-cost window, since neither field has ever shipped — I'd like to change the two lists into one: `shownResultIds?: string[]`. `undefined` = the terminal default (an untouched form behaves exactly as now); a value = exactly what shows (first curation materialises the current shown set); `[]` = explicitly nothing, which today's shape cannot express. The viewer-local layer is orthogonal and unaffected. Three reasons. (1) The disjoint invariant now lives only in the two toggle methods, but the config is data: anything else that writes it (a hand edit, a future consumer) can still produce overlapping lists, and the read side still resolves them wrong — `authorsDefault` adds `chosen` back without subtracting `hidden`. With one list the conflict is unrepresentable rather than discouraged. (2) `[]` as "no results section" is a real authoring choice the two-list shape can never store. (3) #8517 and every later consumer learns one concept instead of two opposite-signed ones. The cost is that a new terminal no longer auto-shows once an author has curated — for a curated page I'd argue that is the more predictable behaviour: a canvas edit should not silently add a card to a page someone laid out. Happy to review it as part of this PR or a follow-up commit on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
