aglinxinyuan commented on code in PR #8396:
URL: https://github.com/apache/texera/pull/8396#discussion_r3938993654
##########
amber/src/main/scala/org/apache/texera/web/TexeraWebApplication.scala:
##########
@@ -125,7 +125,6 @@ class TexeraWebApplication
environment.servlets.setSessionHandler(new SessionHandler)
Review Comment:
Applied — the title is now `chore(amber): remove the commented-out
MockKillWorkerResource`, and the description's opening line says what the file
actually is (every non-blank line after the ASF header is a comment) instead of
calling it a never-registered resource. Re-checked the live window against the
diffs: `41a8a92017` registered it on 2020-08-20 and #1000 (`4a64935c35`)
commented the registration out on 2021-01-30 — about five months registered.
Squash here takes `PR_TITLE` + `PR_BODY` (repo settings), so the corrected
text is what ships; the branch commit's subject is left as is.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
##########
amber/src/main/scala/org/apache/texera/web/TexeraWebApplication.scala:
##########
@@ -125,7 +125,6 @@ class TexeraWebApplication
environment.servlets.setSessionHandler(new SessionHandler)
Review Comment:
Applied — the History table now has two rows, **Introduced by** `41a8a92017`
(2020-08-20, registered live) and **Disabled by** #1000 (`4a64935c35`,
2021-01-30), which commented out the registration line and the whole file body
in the same diff. `134bc9ba64` and #1394 are out of the table — re-read both
diffs, and neither ended the code: the first replaces the named import with
`edu.uci.ics.texera.web.resource._` while
`environment.jersey().register(classOf[MockKillWorkerResource])` sits unchanged
as a context line, and the second — like #1251 (`933b5775e8`) before it — only
re-indents the already-commented line. Issue #8393's title and body carry the
same corrections.
One number I land differently: 2021-01-30 to today is about 5.6 years (five
years to 2026-01-30, plus seven months), not 4.6 — so the text now says "about
five and a half years". That also costs it the "longest-standing item in this
series" line, which is gone from the body: #7451's `ElidableStatement` lost its
last caller on 2021-01-11, and #8333's `PropertyNameConstants` was never
adopted after 2020-08-20.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
