aglinxinyuan opened a new pull request, #8395:
URL: https://github.com/apache/texera/pull/8395
### What changes were proposed in this PR?
Deletes `TupleUtils.json2tuple`, which has no production caller. Pure
deletion, no behaviour change: **−114 lines**.
Its sibling `tuple2json` is live — `ExecutionResultService` uses it — and
stays, as does the object.
### History
| | |
| --- | --- |
| **Introduced by** | #1328 (2021-09-08) — "[Operator Caching Step 3] add
operator cache backend new files and config changes"; the cache read path
called `val newTuple = json2tuple(line)` when rehydrating cached tuples |
| **Usage removed by** | #3111 (2024-11-26) — "Update amber to depend on sub
projects" deleted that call site while splitting amber into sub-projects |
Dead for about two years.
> Reviewer note: removing it frees three imports that only it used —
`AttributeTypeUtils.{inferSchemaFromRows, parseField}`, `JSONUtils.{JSONToMap,
objectMapper}` and `ArrayBuffer`. `TupleSpec`'s "produce identical strings"
test was a `tuple2json → json2tuple` round-trip, so it cannot survive the
removal and goes with it; that also orphans its `tuple2json` import, which
`scalafix` flagged.
### Any related issues, documentation, discussions?
Closes #8392
### How was this PR tested?
Existing tests only — this PR adds none, since it removes a method and the
tests that covered it.
Locally, from the repo root with Java 17:
- `sbt "WorkflowExecutionService/Test/compile"` — success.
- `sbt "WorkflowCore/testOnly *TupleSpec *TupleUtilsSpec"` — 32 tests, all
pass.
- `sbt scalafmtCheckAll "scalafixAll --check"` — clean.
Verification, re-runnable by a reviewer:
```
git grep -n json2tuple # only the deleted method and its tests
git grep -n tuple2json # the live sibling, untouched
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
