yangzhang75 opened a new pull request, #8376:
URL: https://github.com/apache/texera/pull/8376

   ### What changes were proposed in this PR?
   
   Part of the Form View feature stack (parent issue #8011). It builds on PR5 
(#8318); until that merges the diff also shows PR5's files, and PR6's own 
change is the Form View page shell plus the shared spec harness (5 files under 
`workspace/component/workflow-form/`).
   
   The read-only shell of the Form View page:
   
   * Behind the `formViewEnabled` flag it loads the workflow the URL names, and 
redirects to the operator canvas when the workflow does not open in the form 
(its `default_view` is not `FORM`) or the flag is off.
   * Shows the workflow read-only (the graph and its properties are not edited 
here) and offers a switch back to the operator canvas via a full page load.
   * Releases the shared singleton services (graph, shared model, 
computing-unit connection, console, results) on destroy, so nothing left bound 
here follows the user to the next page.
   
   It also adds `workflow-form.spec-harness.ts`, the shared mock/factory these 
specs build the component from; later slices extend it with the dependencies 
they introduce. The title bar's rename/save, the read-only workflow preview, 
the inputs, running and the results are added on top by later PRs of the stack.
   
   ### Any related issues, documentation, discussions?
   
   Closes #8018.
   
   Part of the Form View feature (parent issue #8011); builds on PR5 (#8318).
   
   ### How was this PR tested?
   
   Unit tests (vitest): `workflow-form.component.spec.ts` (7 tests). The page 
component injects ~16 services and heavy child components, so its spec 
constructs it directly with the shared harness's mocks rather than through 
TestBed; template rendering is therefore not exercised, but the component and 
the harness are at 100% of the TypeScript lines this PR adds. The template 
compiles cleanly under `ng build`.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Yes. Co-authored with Claude (Anthropic), reviewed line by line by the 
author before submission.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to