aglinxinyuan commented on code in PR #7464:
URL: https://github.com/apache/texera/pull/7464#discussion_r3916413307
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/DashboardResource.scala:
##########
@@ -56,15 +55,14 @@ object DashboardResource {
The following class describe the available params from the frontend for
full text search.
* @param user The authenticated user performing the search.
* @param keywords A list of search keywords. The API will return
resources that match any of these keywords.
- * @param resourceType The type of the resources to include in the
search results. Acceptable values are "workflow", "project", "file" and "" (for
all types).
+ * @param resourceType The type of the resources to include in the
search results. Acceptable values are "workflow", "dataset" and "" (for all
types).
Review Comment:
Applied your suggestion verbatim — the acceptable values now include
`"model"`. Confirmed against the dispatch that `MODEL_RESOURCE_TYPE` really is
a case before the `case _ => throw`, so the doc was actively misleading.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/DashboardResource.scala:
##########
@@ -190,10 +182,10 @@ object DashboardResource {
class DashboardResource {
/**
- * This method performs a full-text search across all resources -
workflows, projects, and files -
+ * This method performs a full-text search across all resources - workflows
and datasets -
Review Comment:
Applied — "workflows, datasets and models". Also fixed the drifted filter
list you flagged on the next line: it now reads "workflow IDs, model IDs and
operators", matching the documented `modelIds` param.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
