Copilot commented on code in PR #8333:
URL: https://github.com/apache/texera/pull/8333#discussion_r3909719379
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/metadata/PropertyNameConstants.scala:
##########
@@ -27,29 +27,5 @@ package org.apache.texera.amber.operator.metadata
*/
object PropertyNameConstants { // logical plan property names
final val OPERATOR_ID = "operatorID"
- final val OPERATOR_TYPE = "operatorType"
- final val ORIGIN_OPERATOR_ID = "origin"
- final val DESTINATION_OPERATOR_ID = "destination"
- final val OPERATOR_LIST = "operators"
- final val OPERATOR_LINK_LIST = "links"
final val OPERATOR_VERSION = "operatorVersion"
- // common operator property names
- final val ATTRIBUTE_NAMES = "attributes"
- final val ATTRIBUTE_NAME = "attribute"
- final val RESULT_ATTRIBUTE_NAME = "resultAttribute"
- final val SPAN_LIST_NAME = "spanListName"
- final val TABLE_NAME = "tableName"
-
- // physical plan property names
- final val WORKFLOW_ID = "workflowID"
- final val EXECUTION_ID = "executionID"
- final val PARALLELIZABLE = "parallelizable"
- final val LOCATION_PREFERENCE = "locationPreference"
- final val PARTITION_REQUIREMENT = "partitionRequirement"
- // derivePartition is a function type that cannot be serialized
- final val INPUT_PORTS = "inputPorts"
- final val OUTPUT_PORTS = "outputPorts"
- // propagateSchema is a function type that cannot be serialized
- final val IS_ONE_TO_MANY_OP = "isOneToManyOp"
- final val SUGGESTED_WORKER_NUM = "suggestedWorkerNum"
}
Review Comment:
Removing public vals from PropertyNameConstants is a source/binary breaking
API change for any downstream code that compiles against the workflow-operator
artifact, even if this repo no longer references them. Consider keeping the
removed vals as `@deprecated` aliases (with the same string values) for at
least one release to preserve compatibility, then delete later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
