aglinxinyuan opened a new pull request, #8331:
URL: https://github.com/apache/texera/pull/8331
### What changes were proposed in this PR?
Deletes `WorkflowResource.searchWorkflowByOperator` (`GET
/workflow/search-by-operators`), which has no client. Pure deletion, no
behaviour change: **−66 lines**.
Workflow search in the UI goes to the unified `/dashboard/search` resource —
the frontend's search service builds `${API}/dashboard/search`, and no file
references this path.
**Provenance.** Introduced by #1611 (2022-08-07, "Search Workflows Feature")
and genuinely used at the time: the frontend held `WORKFLOW_OPERATOR_URL =
WORKFLOW_BASE_URL + "/search-by-operators"` and called it. #2038 (2023-07-07,
"Allow users to cascade the sharing") deleted that constant when search moved
to the dashboard resource; from that commit on, the only file mentioning the
path is the backend resource itself. Dead for about three years.
> Reviewer note: the frontend's `searchByOperators` test in
`user-workflow.component.spec.ts` is a name coincidence, not a caller — it
drives the filter UI (`component.filters.operators`, `masterFilterList`), which
queries `/dashboard/search`. Nothing in the frontend, or anywhere else, builds
this URL.
Removing the method also frees `Condition` and `noCondition`, which no other
method in `WorkflowResource` uses — scalafix flagged both, and they are the
only other lines touched.
### Any related issues, documentation, discussions?
Closes #8328
### How was this PR tested?
Existing tests only — this PR adds none, since it removes an endpoint and
the one test that covered it.
Locally, from the repo root with Java 17:
- `sbt "WorkflowExecutionService/Test/compile"` — success.
- `sbt "WorkflowExecutionService/testOnly *WorkflowResourceSpec"` — 80
tests, all pass.
- `sbt scalafmtCheckAll "scalafixAll --check"` — clean.
Verification, re-runnable by a reviewer:
```
git grep -rn "search-by-operators\|searchWorkflowByOperator" # only the
deleted method and its test
git grep -rn "dashboard/search" -- frontend/src # where
search actually goes
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
