aglinxinyuan commented on PR #7703: URL: https://github.com/apache/texera/pull/7703#issuecomment-5502463309
Nothing to change this round — thanks for the sweep. Status, since the PR is now blocked only on review state rather than on content: - all four inline threads resolved - CI green on `bf03f8f` — 35 pass, 2 skipping, including `build / pyamber (ubuntu-latest, 3.12)`, which confirms the earlier red was the repo-wide cloudpickle failure and not this branch - rounds 03, 04, 05 and 06 each reported **0 open** The formal review still reads `CHANGES_REQUESTED` from round 02, and the only item in it that was never applied is the first must-fix: *do not delete the migration history — supersede it*. I answered that with the advisory you offered alongside it, and said at the time it was a choice rather than an oversight. So it's your call, and either answer is fine by me: - **Dismiss it** if the README breadcrumb settles the recoverability objection, and this merges as-is. - **Hold it** if you'd still rather the 22 files stay in the tree. That is a coherent position, but it isn't a change to this PR so much as a decision that #7702 shouldn't be done — the PR would become a README with no deletion, and the issue should be closed rather than resolved. Say the word and I'll do exactly that. Not asking you to re-review; just to clear or confirm the block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
