yangzhang75 commented on code in PR #8304:
URL: https://github.com/apache/texera/pull/8304#discussion_r3908681123
##########
frontend/src/app/workspace/service/workflow-graph/model/workflow-action.service.ts:
##########
@@ -98,6 +105,17 @@ export class WorkflowActionService {
private workflowSettings: WorkflowSettings;
private workflowResetSubject = new Subject<void>();
+ // The Form View definition. Presentation, not structure, so it stays out of
the shared
+ // graph (no collaborative merge) and is handled like workflowSettings --
hydrated by
+ // reloadWorkflow, emitted by getWorkflowContent.
Review Comment:
This lives in workflow-action.service.ts, from #8275, and is not part of
this PR (rebased onto main). The observation is architecturally correct:
formBinding is a per-session field kept out of the Yjs shared model, so a
whole-content autosave can persist a stale copy, the same way workflowSettings
already can. It is not reachable yet since the Form View editing UI has not
merged, and it predates this feature as an existing pattern. Moving both
formBinding and workflowSettings into the shared model is a separate
architectural change, tracked outside this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
