carloea2 commented on code in PR #8144:
URL: https://github.com/apache/texera/pull/8144#discussion_r3896990297
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/DashboardResource.scala:
##########
@@ -104,7 +104,7 @@ object DashboardResource {
val q3 = ProjectSearchQueryBuilder.constructQuery(uid, params,
includePublic)
val q4 = DatasetSearchQueryBuilder.constructQuery(uid, params,
includePublic)
q1.unionAll(q3).unionAll(q4)
- case _ => throw new IllegalArgumentException(s"Unknown resource type:
${params.resourceType}")
+ case _ => throw new BadRequestException(s"Unknown resource type:
${params.resourceType}")
Review Comment:
Updated the resource type docs to list dataset instead of file.
##########
amber/src/test/scala/org/apache/texera/web/resource/dashboard/DashboardResourceSpec.scala:
##########
@@ -25,6 +25,7 @@ import
org.apache.texera.web.resource.dashboard.DashboardResource.SearchQueryPar
import org.jooq.impl.{DSL => JDSL}
import org.jooq.{OrderField, SQLDialect}
+import javax.ws.rs.BadRequestException
Review Comment:
Moved the javax import below the org imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
