Yicong-Huang commented on code in PR #7703:
URL: https://github.com/apache/texera/pull/7703#discussion_r3885975444
##########
.github/workflows/automatic-email-notif-on-ddl-change.yml:
##########
@@ -40,9 +40,13 @@ jobs:
FILE=$(git diff --name-only --diff-filter=A \
${{ github.event.pull_request.base.sha }} \
${{ github.event.pull_request.merge_commit_sha }} \
- -- 'sql/updates/')
+ -- 'sql/updates/*.sql')
echo "sql_file=$FILE" >> $GITHUB_OUTPUT
Review Comment:
`git diff --name-only` prints one path per line, so `$FILE` is multi-line
whenever a `ddl-change` PR adds two migrations. The second path lands in
`$GITHUB_OUTPUT` as a bare line with no `key=`, the runner rejects the file,
and the step fails — no notification at all.
Pre-existing, and this PR makes it less likely rather than more. Worth the
line because `benchmarks-pr-comment.yml:111-115` already normalizes before the
same kind of write.
```suggestion
echo "sql_file=${FILE//$'\n'/, }" >> $GITHUB_OUTPUT
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
