aglinxinyuan opened a new issue, #8087:
URL: https://github.com/apache/texera/issues/8087

   ### Task Summary
   
   Three amber engine files have untested logic, two of them with no spec at 
all:
   
   - **`EndChannelHandler`** (14/19 lines, 4/10 branch arms) — decides when a 
worker completes versus holds itself open as input channels end. No spec exists.
   - **`RetryWorkflowHandler`** (1/5 lines, 20%) — no spec exists. Worth 
knowing before starting: `retryWorkflow` has no caller anywhere in `main`; it 
is reachable only as the declared `rpc RetryWorkflow` endpoint in 
`coordinatorservice.proto`, so a test pins the RPC contract rather than live 
behaviour.
   - **`RangeBasedShufflePartitioner`** (17/21) — its `getBucketIndex` never 
executes today, because no operator in `main` declares a `RangePartition`.
   
   A caution for whoever picks this up: the partitioner's spec **does** exist, 
as `RangeBasedShuffleSpec.scala` under `messaginglayer` rather than the 
mirrored `sendsemantics/partitioners` path, and without "Partitioner" in the 
name. A `git ls-files` search keyed on the class name misses it.
   
   Two sibling files in the same area are **not** worth including: 
`DataProcessorRPCHandlerInitializer`'s remaining lines are `???` stubs its 
existing spec deliberately declined, and `OutputManager`'s storage path is 
already covered by the end-to-end workflows.
   
   ### Task Type
   
   - [x] Testing / QA
   
   ### Was this issue authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to