mengw15 commented on code in PR #7418:
URL: https://github.com/apache/texera/pull/7418#discussion_r3740573054
##########
frontend/src/app/dashboard/component/user/user-project/user-project-list-item/user-project-list-item.component.spec.ts:
##########
@@ -77,6 +80,14 @@ describe("UserProjectListItemComponent", () => {
UserProjectService,
NzModalService,
{ provide: UserService, useClass: StubUserService },
+ // The expanded description renders <markdown>, which needs a
MarkdownService.
+ // Stub it (as the sibling dashboard specs do) so the test never
depends on
+ // the real markdown pipeline; `reload$` stays empty so nothing
re-renders
+ // asynchronously.
+ {
+ provide: MarkdownService,
+ useValue: { parse: vi.fn(async () => ""), render: vi.fn(), reload$:
EMPTY },
+ },
Review Comment:
Update: after rebasing onto `main` (#7415 landed on this file), the stub is
gone entirely — that PR added `MarkdownModule.forRoot()` to the TestBed, which
is kept as-is here. So this thread is moot; leaving the note for the record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
