aglinxinyuan opened a new issue, #7421:
URL: https://github.com/apache/texera/issues/7421
### Task Summary
`UserWorkflowListItemComponent`'s spec calls the component's methods
directly, so the template's own decisions are unrendered: which control a click
reaches, what value an edit forwards, whether a read-only row may still be
edited inline, and which actions a row offers.
Worth pinning:
| Template decision | Why it matters |
|---|---|
| `(focusout)="confirmUpdateWorkflowCustomName(customName.value)"` | the
input is seeded with the current name, so binding `workflow.name` instead would
look right on screen while discarding every rename |
| `(click)="editingDescription = editable"` | the only expression of the
read-only gate; without it a shared read-only row opens an editor whose save
the backend rejects |
| `{{accessLevel}} access shared by {{ownerName}}` | shown only to a
non-owner; the two interpolations are swappable |
| `(click)="removeWorkflowFromProject(projectID)"` | must pass the `ngFor`
loop variable, not the component's `pid` |
| `duplicated.emit()` vs `deleted.emit()` | adjacent icon buttons; emitting
the wrong one is destructive |
| `*ngIf="this.config.env.workflowExecutionsTrackingEnabled"` | the
executions action must appear only when configured on |
Notes for whoever picks this up:
- ng-zorro consumes the `nz-tooltip` attribute, and an interpolated title is
a property binding that never reaches the DOM. Locate elements through
`NzTooltipDirective` and read `directiveTitle`; an attribute selector finds
nothing.
- `StubWorkflowPersistService` does not declare `updateWorkflowName`, so it
cannot be spied on — supply a local stub.
- The shared `testUserProjects` fixture stores colours already carrying a
`'#'` while the template prepends one, so every tag fails the format check and
takes the dark arm. Supply local colours to reach both arms.
### Task Type
- [ ] Refactor / Cleanup
- [ ] DevOps / Deployment / CI
- [x] Testing / QA
- [ ] Documentation
- [ ] Performance
- [ ] Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
