aglinxinyuan commented on PR #7415: URL: https://github.com/apache/texera/pull/7415#issuecomment-5224665752
Both suppressed comments were worth acting on — fixed in e44b491952. **The `editable` gating.** The read-only case did already assert the add-description control, but the positive case asserted only the rename control and the existence of the actions container, so it would not have noticed either action disappearing. It now checks the add-description control too and counts the two action buttons. Verified: hiding the add-description button, and dropping one action, each now fail — neither did before. One implementation note in case it saves someone time: `nz-list-item-action` renders as an `<li>`, so counting `nz-list-item-action` elements finds zero. The assertion counts the buttons inside `ul[nz-list-item-actions]`. **The character counter.** Right — it only saw the initial value, so a counter wired to `entry.description.length` instead of `descriptionBox.value.length` would have passed. The test now types into the textarea and asserts the count follows the box; that mutation is red as of this commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
