aglinxinyuan commented on PR #7408: URL: https://github.com/apache/texera/pull/7408#issuecomment-5223869337
Picking up the two suppressed comments as well, since both were worth acting on. **The double `ngOnInit`** — correct, and fixed in the commit above. The helper assigned the inputs and called `ngOnInit()` by hand, then `detectChanges()` invoked it again, so it ran twice per test and rebuilt the cover-image cache on top of itself. Now it uses `fixture.componentRef.setInput` for the two `@Input()`s and lets the first change-detection cycle drive the lifecycle, as at runtime. Re-ran the template mutation set afterwards to confirm the change didn't weaken anything — all eight still fail. **`HttpClientTestingModule`** — already removed in 0054c45e52. Worth noting that this suppressed version gives the accurate reason (`StubUserService` doesn't inject `HttpClient`); the comment that was posted inline said the module had already been dropped from the TestBed imports, which wasn't the case. Same conclusion, sounder reasoning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
