aglinxinyuan commented on code in PR #7339:
URL: https://github.com/apache/texera/pull/7339#discussion_r3739345262
##########
frontend/src/app/dashboard/component/dashboard.component.scss:
##########
@@ -40,6 +40,16 @@ texera-user-icon {
padding: 0 24px;
}
+.nav-login-link {
+ flex: none;
Review Comment:
Tested locally, the same effect can be achieved with just
```
.nav-login-link {
margin: 0 8px;
padding: 0 36px;
}
```
margin is also kind of unnecessary.
##########
frontend/src/app/hub/component/login/texera-login.component.scss:
##########
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+$text-secondary: rgba(0, 0, 0, 0.45);
+$error: #ff4d4f;
+$bg: #f0f2f5;
+$card-bg: #fff;
+
+:host {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ min-height: 100vh;
+ padding: 32px 16px;
+ background: $bg;
+ -webkit-font-smoothing: antialiased;
Review Comment:
Not necessary.
##########
frontend/src/app/hub/component/login/texera-login.component.scss:
##########
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+$text-secondary: rgba(0, 0, 0, 0.45);
+$error: #ff4d4f;
Review Comment:
You don't need a var for something only being used once.
##########
frontend/src/app/hub/component/login/texera-login.component.scss:
##########
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+$text-secondary: rgba(0, 0, 0, 0.45);
+$error: #ff4d4f;
+$bg: #f0f2f5;
+$card-bg: #fff;
+
+:host {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ min-height: 100vh;
+ padding: 32px 16px;
+ background: $bg;
+ -webkit-font-smoothing: antialiased;
+}
+
+* {
+ box-sizing: border-box;
+}
+
+.card {
+ width: 100%;
Review Comment:
Not necessary.
##########
frontend/src/app/hub/component/login/texera-login.component.scss:
##########
@@ -0,0 +1,291 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+:host {
Review Comment:
You are right. If you want to change the background color of the page, you
probably must use `:host` to avoid an unnecessary outer div.
##########
frontend/src/app/hub/component/login/texera-login.component.scss:
##########
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+$text-secondary: rgba(0, 0, 0, 0.45);
+$error: #ff4d4f;
+$bg: #f0f2f5;
+$card-bg: #fff;
+
+:host {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ min-height: 100vh;
+ padding: 32px 16px;
+ background: $bg;
+ -webkit-font-smoothing: antialiased;
+}
+
+* {
+ box-sizing: border-box;
+}
+
+.card {
+ width: 100%;
+ max-width: 400px;
+ background: $card-bg;
+ border-radius: 8px;
+ box-shadow:
+ 0 6px 16px -8px rgba(0, 0, 0, 0.08),
+ 0 9px 28px 0 rgba(0, 0, 0, 0.05),
+ 0 12px 48px 16px rgba(0, 0, 0, 0.03);
+ padding: 40px 36px 32px;
+}
+
+.brand {
+ display: flex;
Review Comment:
Not necessary.
Replace the first 3 lines with:
`text-align: center;`
and change the sub from `span` to `div`.
##########
frontend/src/app/dashboard/component/dashboard.component.html:
##########
@@ -249,11 +249,17 @@
<ng-container *ngIf="isLogin">
<texera-user-icon></texera-user-icon>
</ng-container>
- <asl-google-signin-button
- *ngIf="!isLogin && this.config.env.googleLogin"
- type="standard"
- size="large"
- [width]="200"></asl-google-signin-button>
+ <!-- The only route into the login page for a logged-out visitor;
every other way in
Review Comment:
Don't need to comment here.
##########
frontend/src/app/hub/component/login/texera-login.component.scss:
##########
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+$text-secondary: rgba(0, 0, 0, 0.45);
+$error: #ff4d4f;
+$bg: #f0f2f5;
+$card-bg: #fff;
+
+:host {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ min-height: 100vh;
+ padding: 32px 16px;
+ background: $bg;
+ -webkit-font-smoothing: antialiased;
+}
+
+* {
+ box-sizing: border-box;
Review Comment:
Not necessary.
##########
frontend/src/app/hub/component/login/texera-login.component.scss:
##########
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+$text-secondary: rgba(0, 0, 0, 0.45);
+$error: #ff4d4f;
+$bg: #f0f2f5;
+$card-bg: #fff;
+
+:host {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ min-height: 100vh;
+ padding: 32px 16px;
Review Comment:
Not necessary.
##########
frontend/src/app/hub/component/login/texera-login.component.scss:
##########
@@ -0,0 +1,291 @@
+/**
Review Comment:
Please try to simplify the CSS further. Don't use `flex` too much. For such
a simple layout, `flex` is usually overkill and makes things more complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
