kz930 opened a new pull request, #7396:
URL: https://github.com/apache/texera/pull/7396

   ### What changes were proposed in this PR?
   
   Bubble Chart's Color-Column was declared `required = true` with `@NotNull`, 
but the generated Python reads it only inside the Enable Color branch. The 
effect was that a freshly dropped Bubble Chart stayed invalid until the user 
picked a color column, even when they wanted plain bubbles — and the column 
they picked was then never used.
   
   This PR makes the field optional and puts it behind the toggle via 
`toggleHidden`, so it disappears from the panel when Enable Color is off. That 
matches Ternary Plot, which has the same toggle-plus-column pair and already 
declares its color field optional.
   
   The color decision also moves out of the generated Python and into Scala. 
The old template emitted an `if '...' == 'true':` comparison over a Scala 
Boolean; it is now a `colorArg` computed at build time, guarded on both the 
toggle and the column being non-empty. That second half matters: with the 
required flag gone, an empty column would otherwise reach 
`px.scatter(color='')`, which plotly rejects — the same failure fixed for Bar 
Chart in #6792.
   
   Behavior for existing workflows is unchanged. `enableColor` keeps its 
meaning, so no saved chart changes appearance.
   
   The operator reference page is updated to match the new requirement and 
description.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7395
   
   ### How was this PR tested?
   
   Existing `BubbleChartOpDescSpec` passes unchanged, including the assertion 
that pins the no-color output line. Three cases were added to it, covering the 
toggle-and-column matrix: enabled with a column chosen (color is emitted), 
enabled with no column (color is omitted rather than emitted empty), and 
disabled with a column chosen (the column is not emitted).
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to