Yicong-Huang commented on code in PR #6037:
URL: https://github.com/apache/texera/pull/6037#discussion_r3739295764
##########
amber/src/test/scala/org/apache/texera/amber/engine/architecture/worker/WorkerSpec.scala:
##########
@@ -173,7 +173,7 @@ class WorkerSpec
)
val addPort1 = AsyncRPCClient.ControlInvocation(
METHOD_ASSIGN_PORT,
- AssignPortRequest(mockPortId, input = true, mkSchema(1).toRawSchema,
List(""), List()),
+ AssignPortRequest(mockPortId, input = true, mkSchema(1).toRawSchema,
List(), List()),
Review Comment:
Nothing asserts the input port actually registered — the tests only observe
it through tuples arriving before the 3 s deadline. And the `AssertionError`
that would flag a future mismatch is still swallowed: `AsyncRPCServer` turns it
into a `ControlError` reply that `mkWorker`'s handler drops at line 145. So a
re-introduced mismatch returns as the same flaky timeout, not a named failure.
Worth asserting registration (e.g. `dp.inputManager.getAllPorts`) so the next
one fails loudly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
