eugenegujing opened a new pull request, #7373:
URL: https://github.com/apache/texera/pull/7373

   ### What changes were proposed in this PR?
   
   One new test file, no source changes: `ScanSourceOpDescSpec` (18 tests), a 
characterization spec for the abstract base of the six file-scan descriptors, 
which had no direct test coverage. It pins the `operatorInfo` naming formula 
(the "Unknown" fallback, the empty-type "File Scan" form, the a/an article 
choice) and the default output port, the display names not asserted anywhere 
else (both CSV scans render as "CSV File Scan"), the property defaults, 
`setResolvedFileName`'s `toASCIIString` percent-encoding, `fileResolved()`, 
reflection-based equals/hashCode (fresh instances differ by the random-UUID 
operator id; the `@JsonIgnore`'d `INFER_READ_LIMIT` still participates in 
equality), and the serialized JSON shape (`@JsonIgnore` fields stay off the 
wire, unset `Option` fields are omitted).
   
   The abstract class is instantiated through private stub subclasses, 
following the existing `SklearnModelOpDescSpec` / `SQLSourceOpDescSpec` pattern.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7369.
   
   ### How was this PR tested?
   
   - `sbt "WorkflowOperator/testOnly 
org.apache.texera.amber.operator.source.scan.ScanSourceOpDescSpec"` — 18/18 
pass.
   - `sbt "WorkflowOperator/testOnly 
org.apache.texera.amber.operator.source.scan.*"` — 137/137 pass, no regressions 
in the scan package.
   - `scalafmtCheck` passes.
   - Mutation-checked: flipping the vowel set in `operatorInfo` or the output 
port's `blocking` flag each makes exactly the pinning test fail; both reverted.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Co-authored by: Claude Code (Claude Fable 5)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to