carloea2 commented on code in PR #7341: URL: https://github.com/apache/texera/pull/7341#discussion_r3725568012
########## common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/visualization/bubbleChart/BubbleChartOpDesc.scala: ########## @@ -39,6 +39,16 @@ import javax.validation.constraints.NotNull */ // type can be numerical only +// The z column is the bubble size, which plotly express divides by a scale +// factor, so text aborts the run. The x and y axes are positions and take any +// type, the way a scatter plot's do. +@JsonSchemaInject(json = """ Review Comment: This new schema behavior has no committed regression coverage. Please generate the schemas for both changed descriptors and assert that each rule targets the intended property with exactly integer, long, and double. The tests should also make clear that string is not accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
