Yicong-Huang commented on code in PR #6315:
URL: https://github.com/apache/texera/pull/6315#discussion_r3560768242
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/util/IcebergUtil.scala:
##########
@@ -59,32 +58,14 @@ object IcebergUtil {
private val LARGE_BINARY_FIELD_SUFFIX = "__texera_large_binary_ptr"
/**
- * Creates and initializes a HadoopCatalog with the given parameters.
* - Uses an empty Hadoop `Configuration`, meaning the local file system
(or `file:/`) will be used by default
* instead of HDFS.
* - The `warehouse` parameter specifies the root directory for storing
table data.
* - Sets the file I/O implementation to `HadoopFileIO`.
*
* @param catalogName the name of the catalog.
* @param warehouse the root path for the warehouse where the tables are
stored.
- * @return the initialized HadoopCatalog instance.
*/
Review Comment:
remove the comments as well if we remove the method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
