Copilot commented on code in PR #6411: URL: https://github.com/apache/texera/pull/6411#discussion_r3583796760
########## config-service/build.sbt: ########## @@ -84,7 +84,7 @@ libraryDependencies ++= Seq( "io.dropwizard" % "dropwizard-core" % dropwizardVersion, "io.dropwizard" % "dropwizard-auth" % dropwizardVersion, // Dropwizard Authentication module "com.fasterxml.jackson.module" %% "jackson-module-scala" % "2.18.8", - "jakarta.ws.rs" % "jakarta.ws.rs-api" % "3.1.0", // Ensure Jakarta JAX-RS API is available + "jakarta.ws.rs" % "jakarta.ws.rs-api" % "4.0.0", // Ensure Jakarta JAX-RS API is available Review Comment: Bumping jakarta.ws.rs-api will change the bundled JAR set for config-service, but config-service/LICENSE-binary and config-service/NOTICE-binary still reference jakarta.ws.rs-api 3.1.0. CI enforces NOTICE-binary drift and checks LICENSE-binary against the unzipped dist, so this PR will likely fail until those files are regenerated/updated. ########## config-service/build.sbt: ########## @@ -84,7 +84,7 @@ libraryDependencies ++= Seq( "io.dropwizard" % "dropwizard-core" % dropwizardVersion, "io.dropwizard" % "dropwizard-auth" % dropwizardVersion, // Dropwizard Authentication module "com.fasterxml.jackson.module" %% "jackson-module-scala" % "2.18.8", - "jakarta.ws.rs" % "jakarta.ws.rs-api" % "3.1.0", // Ensure Jakarta JAX-RS API is available + "jakarta.ws.rs" % "jakarta.ws.rs-api" % "4.0.0", // Ensure Jakarta JAX-RS API is available Review Comment: ConfigService depends on common/auth and common/resource, which currently compile against jakarta.ws.rs-api 3.0.0, while this module now pins 4.0.0. Because the build uses ConflictManager.latestRevision, the packaged runtime classpath for ConfigService will likely resolve to 4.0.0, meaning common modules compiled against 3.0.0 will run with 4.0.0. To avoid potentially subtle binary/source incompatibilities on a major JAX-RS upgrade, the version should be made consistent across these subprojects (e.g., bump common/auth and common/resource, or centralize/override the version in one place). ########## file-service/build.sbt: ########## @@ -88,7 +88,7 @@ libraryDependencies ++= Seq( "io.dropwizard" % "dropwizard-core" % dropwizardVersion, "io.dropwizard" % "dropwizard-auth" % dropwizardVersion, // Dropwizard Authentication module "com.fasterxml.jackson.module" %% "jackson-module-scala" % "2.18.8", - "jakarta.ws.rs" % "jakarta.ws.rs-api" % "3.1.0", // Ensure Jakarta JAX-RS API is available + "jakarta.ws.rs" % "jakarta.ws.rs-api" % "4.0.0", // Ensure Jakarta JAX-RS API is available Review Comment: Bumping jakarta.ws.rs-api will change the bundled JAR set for file-service, but file-service/LICENSE-binary and file-service/NOTICE-binary still reference jakarta.ws.rs-api 3.1.0. CI enforces NOTICE-binary drift and checks LICENSE-binary against the unzipped dist, so this PR will likely fail until those files are regenerated/updated. ########## file-service/build.sbt: ########## @@ -88,7 +88,7 @@ libraryDependencies ++= Seq( "io.dropwizard" % "dropwizard-core" % dropwizardVersion, "io.dropwizard" % "dropwizard-auth" % dropwizardVersion, // Dropwizard Authentication module "com.fasterxml.jackson.module" %% "jackson-module-scala" % "2.18.8", - "jakarta.ws.rs" % "jakarta.ws.rs-api" % "3.1.0", // Ensure Jakarta JAX-RS API is available + "jakarta.ws.rs" % "jakarta.ws.rs-api" % "4.0.0", // Ensure Jakarta JAX-RS API is available Review Comment: FileService depends on common/auth and common/resource, which currently compile against jakarta.ws.rs-api 3.0.0, while this module now pins 4.0.0. Because the build uses ConflictManager.latestRevision, the packaged runtime classpath for FileService will likely resolve to 4.0.0, meaning common modules compiled against 3.0.0 will run with 4.0.0. To avoid potentially subtle binary/source incompatibilities on a major JAX-RS upgrade, the version should be made consistent across these subprojects (e.g., bump common/auth and common/resource, or centralize/override the version in one place). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
