Mrudhulraj commented on PR #6016: URL: https://github.com/apache/texera/pull/6016#issuecomment-4928321538
Yes, I tried a bit with AI -> It isn't able to generate the testcases due to lack of access to DatasetResource object Let me explain further: 1. Refer: `DatasetResource.scala` file in the amber project -> Only `DashBoardDataset `class is defined, various utilities like `getDashboardDataset`/`createDataset` is **_missing_**, instead it is defined in file-service `DatasetResource.scala`. 2. Since file-service has the required utilities, I tried creating the spec file in file-service. Here, `DashboardResource` is inaccessible as it is defined in the amber project again (not accessible from file-service). Hope this clears !! AI's recommendation: 1. Migrate DatasetResource to common shared libraries similar to workflow-core 2. Add file-service to amber/engine service as a dependency -> Not recmmended as it affects the decoupled nature. Why #6017 works? 1. Both `DashboardResource `and `WorkflowResource` are in amber project. Also the spec file already exists. -> In the future, this might also create a problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
