Raja-Hamid opened a new pull request, #6292: URL: https://github.com/apache/texera/pull/6292
### What changes were proposed in this PR? Sidebar active-route highlighting was inconsistent (#3490). The **About** and **Feedback** items were plain `nz-menu-item`s with a `[routerLink]` but **no `nzMatchRouter`**, so — unlike Your Work / Admin / Hub — they never entered ng-zorro's `.ant-menu-item-selected` state and weren't highlighted when active. Added `nzMatchRouter="true"` to both, giving them the same background + blue text + right accent bar. Note on the report: the issue also lists **Hub**, but the Hub items already have `nzMatchRouter` and route to real paths, so they already highlight correctly (confirmed on the running app) — no Hub change was needed. <img width="1536" height="697" alt="image" src="https://github.com/user-attachments/assets/7814362b-1361-4d34-8363-0075298fee15"; /> <img width="1536" height="697" alt="image" src="https://github.com/user-attachments/assets/21a3db41-baa2-4d81-bb19-24c34200694f"; /> <img width="1536" height="702" alt="image" src="https://github.com/user-attachments/assets/8b84fc40-c255-40ba-a557-cdfa1dda6c69"; /> ### Any related issues, documentation, or discussions? Closes #3490 ### How was this PR tested? Unit tests (Vitest) — added #3490 cases to `dashboard.component.spec.ts` asserting the About and Feedback items enable `nzMatchRouter` (with a Your Work item as a passing reference): corepack yarn ng test --watch=false --include="**/dashboard.component.spec.ts" → **14/14 passing** (the 2 new About/Feedback cases were red before the fix). Manual: `ng serve`, navigated to `/about` — About now shows the active highlight like Your Work; confirmed Hub items already highlight. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Yes, Alongside Claude Code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
