Yicong-Huang commented on code in PR #6271: URL: https://github.com/apache/texera/pull/6271#discussion_r3546150106
########## .github/scripts/smoke-boot.sh: ########## Review Comment: the point is I want to have less scripts, so testing env can be closer to dev env, and closer to prod env. if we have separated scripts, it is easy to drift: something works in dev, but won't pass in CI, or something works in CI, won't actually work in prod. ########## .github/scripts/smoke-boot.sh: ########## Review Comment: do we need this smoke-boot script, or maybe `local-dev.sh up <service>` is enough? ########## .github/scripts/smoke-boot.sh: ########## Review Comment: maybe we can write the simple logic: try local-dev.sh up <service> detect port licensing timeout after 5s -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
