Copilot commented on code in PR #6224: URL: https://github.com/apache/texera/pull/6224#discussion_r3540260171
########## project/plugins.sbt: ########## @@ -40,5 +40,5 @@ libraryDependencies ++= Seq( // PostgresDatabase.loadForeignKeys can't read (it looks up lowercase key_seq), // breaking JOOQ code generation. Fixed only in jOOQ 3.20+ (jOOQ/jOOQ#17873); until // the codegen jOOQ is upgraded, keep this driver at the last compatible release. - "org.postgresql" % "postgresql" % "42.7.4" + "org.postgresql" % "postgresql" % "42.7.13" Review Comment: This bumps the build-time pgjdbc version to 42.7.13, but the comment immediately above states that pgjdbc >= 42.7.5 changes metadata column label casing (KEY_SEQ) in a way that breaks jOOQ 3.16.x code generation (and jooq-codegen here is still 3.16.23). As-is, this likely breaks codegen builds unless jOOQ is upgraded to 3.20+ as noted. ########## amber/build.sbt: ########## @@ -255,7 +255,7 @@ libraryDependencies += "com.flipkart.zjsonpatch" % "zjsonpatch" % "0.4.16" libraryDependencies += "io.reactivex.rxjava3" % "rxjava" % "3.1.12" // https://mvnrepository.com/artifact/org.postgresql/postgresql -libraryDependencies += "org.postgresql" % "postgresql" % "42.7.12" +libraryDependencies += "org.postgresql" % "postgresql" % "42.7.13" Review Comment: After bumping pgjdbc to 42.7.13 here, the Amber LICENSE inventory appears to still list org.postgresql.postgresql-42.7.12.jar (amber/LICENSE-binary-java). Please update the corresponding LICENSE-binary(-java) entries (and consider consolidating the pgjdbc version across subprojects to avoid silent eviction between 42.7.10/42.7.13). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
