aglinxinyuan commented on PR #6189: URL: https://github.com/apache/texera/pull/6189#issuecomment-4888747200
Tested the major bump manually — it's safe for our usage. - Our 3 call sites just register the module and set `cursors: true`; rendering is driven by y-quill's `QuillBinding` and we ship no custom `.ql-cursor*` CSS, so the v4 breaking changes (all CSS-class / touch-device behavior) don't apply. - 4.3.0 is still built against `quill: ^1.3.7`, has no peer deps, and keeps the default export — resolves cleanly under our `moduleResolution: bundler`. - Repro'd our exact config (`theme: "bubble"`, `cursors: true`) with quill 1.3.7 + quill-cursors 4.3.0: module registers, cursor caret + name flag render correctly. `LICENSE-binary` is already synced to 4.3.0 in this PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
