aglinxinyuan commented on PR #6170: URL: https://github.com/apache/texera/pull/6170#issuecomment-4888346290
LGTM — verified locally, since `pyright-language-service` isn't wired into any CI stack (a `**/package.json`-only change maps to the `dependencies` label, which triggers no build), so nothing here is actually exercised by the pipeline. Installed the PR's exact lockfile and smoke-tested the language server by hand: - `yarn install --frozen-lockfile` (Yarn 1, matching the committed `# yarn lockfile v1`) — clean, `Done in 12.59s`, no lockfile drift. - Resolves + installs `[email protected]` (integrity `sha512-03S/vmS5…`); `node_modules/pyright/dist/pyright-langserver.js` present (the path `src/main.ts` hard-codes). - `pyright --version` → `pyright 1.1.411`. - `pyright-langserver --stdio` boots (`Pyright language server 1.1.411 starting`) and answers an LSP `initialize` with the full capability set — hover, completion, go-to-definition, references, rename, code actions, signature help, call hierarchy. No `LICENSE-binary`/`NOTICE` impact either — `pyright` isn't a tracked binary dep here and the service ships in no dist. Safe to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
