aglinxinyuan opened a new pull request, #6148:
URL: https://github.com/apache/texera/pull/6148

   ### What changes were proposed in this PR?
   
   Adds `WorkflowActorSpec` (new) for the abstract `WorkflowActor` base 
(amber), which had no dedicated spec. Uses Pekko TestKit and the existing 
`TrivialControlTester` subclass to drive the receive behaviors in-JVM (no 
Python workers):
   
   - `CreditRequest` → `CreditResponse(channel, 0)`, and `CreditResponse` 
forwarding to the transfer service;
   - dead-letter handling — retry-to-self when the destination is this actor, 
and actor-ref removal otherwise;
   - `RegisterActorRef` storing the ref, and `GetActorRef` for an unknown id 
forwarding to the parent;
   - `sendMessageFromLogWriterToActor` / `handleTriggerSend` self-send and 
delegate paths.
   
   `setupReplay` is left uncovered (it needs the serde/checkpoint-storage 
ceremony and has a known Windows file-handle quirk) — a candidate for a 
follow-up. No production code changed.
   
   ### Any related issues, documentation, discussions?
   
   Coverage gaps identified from the Codecov report for `apache/texera` (amber 
module coverage push toward 80%).
   
   ### How was this PR tested?
   
   ```
   sbt "WorkflowExecutionService/testOnly *WorkflowActorSpec"
   ```
   
   All 10 pass. `scalafmt` and `scalafixAll --check` are clean.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to