aglinxinyuan opened a new pull request, #6127:
URL: https://github.com/apache/texera/pull/6127

   ### What changes were proposed in this PR?
   
   Adds unit-test coverage for three value/utility classes in 
`common/workflow-core` that Codecov reports as having uncovered lines:
   
   - **`PhysicalFileNodeSpec`** (new) — covers the `PhysicalFileNode` value 
class: constructor/getters, `isFile`/`isDirectory`, `addChildNode` success and 
the direct-subpath guard failure, `equals`/`hashCode` (which deliberately 
excludes `size`), and the recursive `getAllFileRelativePaths` traversal.
   - **`SchemaSpec`** (extended) — adds `hashCode`/`equals` cases (including 
non-`Schema` operands), both duplicate-name rejection paths (`add(Iterable)` 
and `add(Attribute)`), and a Jackson JSON round-trip.
   - **`VFSURIFactorySpec`** (extended) — adds the missing-value guard where a 
required key is the final path segment.
   
   No production code is changed; this is test-only.
   
   ### Any related issues, documentation, discussions?
   
   Coverage gaps identified from the Codecov report for `apache/texera`.
   
   ### How was this PR tested?
   
   New/extended ScalaTest specs, run locally:
   
   ```
   sbt "WorkflowCore/testOnly *PhysicalFileNodeSpec *SchemaSpec 
*VFSURIFactorySpec"
   ```
   
   All pass. `scalafmt` and `scalafixAll --check` are clean.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to