Yicong-Huang opened a new pull request, #6090:
URL: https://github.com/apache/texera/pull/6090

   ### What changes were proposed in this PR?
   
   Refactor of `build.sbt` only — no behavior change.
   
   `asfLicensingSettings` bundled three unrelated concerns: ASF licensing 
(`AddMetaInfLicenseFiles.*`), the jacoco coverage-report format, and the 
universal JVM flags. Its licensing-centric name and the adjacent 
`coverageReportSettings` comment implied coverage was a licensing concern, 
which is misleading.
   
   This PR:
   - Narrows `asfLicensingSettings` and `asfLicensingSettingsWithVendored` to 
hold **only** the licensing settings, so the name is accurate.
   - Introduces `commonModuleSettings` / `commonModuleSettingsWithVendored` as 
the per-module bundle (licensing + coverage + JVM flags) that each module 
applies via `.settings(...)`.
   - Updates the 15 module call sites and rewrites the misleading comment to 
state the three concerns are independent, grouped only for reuse.
   
   ### Any related issues, documentation, discussions?
   
   Closes #6089
   
   ### How was this PR tested?
   
   No new tests — this is a behavior-preserving build refactor. Verified 
locally with JDK 17:
   - `sbt projects` loads the build cleanly; all 15 projects resolve with no 
errors.
   - `sbt "show NotebookMigrationService/jacocoReportSettings"` still reports 
`ScalaHTML + XML` formats, confirming coverage settings continue to reach every 
module through the new `commonModuleSettings` path.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 4.8)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to