Yicong-Huang opened a new pull request, #6025:
URL: https://github.com/apache/texera/pull/6025

   ### What changes were proposed in this PR?
   
   The usage banner in `bin/local-dev/main.sh` claimed Docker infra is **not**
   managed by the script and that you must bring it up yourself before `up`. 
That
   contradicts the actual code: `cmd_up` calls `infra_up` (which runs `docker
   compose up -d` against project `texera-local-dev`) and `cmd_down` calls
   `infra_down` for any docker targets.
   
   ```
   Before:  comment says "infra is NOT managed here -- bring those up yourself"
   After:   comment says "infra IS managed: `up` brings it up, `down` tears it 
down"
   ```
   
   Comment-only change; no behavior change.
   
   ### Any related issues, documentation, discussions?
   
   None — documentation/comment-only fix (issue-first is excepted for docs).
   The sibling `bin/local-dev/README.md` already documents the correct behavior
   ("infra in docker, JVM + frontend native"); this just realigns the script's
   own banner.
   
   ### How was this PR tested?
   
   No tests — comment-only change. Verified the described behavior by reading
   `cmd_up` → `infra_up` (`docker compose up -d`, project `texera-local-dev`) 
and
   `cmd_down` → `infra_down`, and by running `bin/local-dev.sh up`, which 
brought
   up postgres/minio/lakefs/lakekeeper/litellm automatically (14/14 services
   healthy) with no manual `docker compose` step.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to