Yicong-Huang opened a new pull request, #6006:
URL: https://github.com/apache/texera/pull/6006
### What changes were proposed in this PR?
The nine per-service Dockerfiles sat next to general-purpose tooling
(`build-images.sh`, `local-dev.sh`, `single-node/`, etc.) at the top of `bin/`.
Tuck them into a dedicated `bin/dockerfiles/` subdirectory so the top of `bin/`
stays scannable:
```
bin/ bin/dockerfiles/
├── access-control-service.dockerfile ──→
access-control-service.dockerfile
├── agent-service.dockerfile ──→ agent-service.dockerfile
├── computing-unit-master.dockerfile ──→
computing-unit-master.dockerfile
├── computing-unit-worker.dockerfile ──→
computing-unit-worker.dockerfile
├── config-service.dockerfile ──→ config-service.dockerfile
├── file-service.dockerfile ──→ file-service.dockerfile
├── texera-web-application.dockerfile ──→
texera-web-application.dockerfile
├── workflow-compiling-service.dockerfile ──→
workflow-compiling-service.dockerfile
└── workflow-computing-unit-managing-service.dockerfile
──→
workflow-computing-unit-managing-service.dockerfile
```
Refs updated to follow the move:
* `bin/build-images.sh`: glob `dockerfiles/*.dockerfile` (script stays cd'd
in `bin/` so the pylsp + y-websocket-server build stages further down keep
working with their `./pylsp` / `./y-websocket-server` relative paths, and the
`..` build context still resolves to the repo root).
* `.github/workflows/build-and-push-images.yml`: `cd bin/dockerfiles` for
service discovery; matrix `dockerfile` entries reference
`bin/dockerfiles/<svc>.dockerfile`.
* `bin/README.md`: build-from-source example path.
`bin/pylsp/Dockerfile` and `bin/y-websocket-server/Dockerfile` stay where
they are — those live inside service source trees (their `COPY` statements
reference adjacent files), not standalone deployment artifacts.
Pure structural move. No image-name changes, no docker-compose / k8s value
changes, no test changes. Build context is still the repo root for every
dockerfile.
### Any related issues, documentation, discussions?
Closes #6005.
### How was this PR tested?
* `bash -n bin/build-images.sh` → syntax OK.
* `python -c 'import yaml;
yaml.safe_load(open(".github/workflows/build-and-push-images.yml"))'` → YAML
loads.
* Simulated the build-images.sh dockerfile-discovery step from its `cwd`:
`(cd bin && ls dockerfiles/*.dockerfile)` lists all 9.
* Sanity-grepped `bin/<svc>.dockerfile` patterns across `*.sh / *.yml /
*.yaml / *.md / *.scala / *.py / *.ts / Dockerfile*` (excluding `.git/`,
`target/`, `node_modules/`); no stale references remain.
* `bash bin/local-dev/tests/test_local_dev_sh.sh` → `10 passed, 0 failed`
(this branch doesn't touch local-dev, but verified nothing in the smoke suite
expected a bin/<svc>.dockerfile path).
Image builds themselves can't be exercised locally without pushing to
ghcr.io; the matrix-build workflow uses the new paths and will surface any
breakage on first dispatch.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Anthropic, Claude Opus 4.7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
