Yicong-Huang opened a new pull request, #5973: URL: https://github.com/apache/texera/pull/5973
### What changes were proposed in this PR? Tier-2 follow-up to **#5971** (which deletes `deploy-daemon.sh` / `deploy-docker.sh` / `build.sh` / `frontend-dev.sh`). With those gone, the per-service shell wrappers they called into are orphans — each is a single-line invocation of the `target/<svc>-*/bin/<svc>` dist launcher that `bin/local-dev.sh` or each service's Dockerfile already runs directly. Delete: | File | What it did | Why dead | |---|---|---| | `bin/server.sh` | `(cd amber && target/texera-*/bin/texera-web-application)` | **Already broken** — dist is `amber-*` now, not `texera-*`. Only callers were the deleted deploy scripts. | | `bin/config-service.sh` | `target/config-service-*/bin/config-service` | One-liner; only caller was `deploy-daemon.sh`. | | `bin/file-service.sh` | same shape | same. | | `bin/computing-unit-managing-service.sh` | same shape | same. | | `bin/workflow-compiling-service.sh` | same shape | same. | | `bin/workflow-computing-unit.sh` | `target/texera-*/bin/computing-unit-master` | **Already broken** (`texera-*` vs `amber-*`); only deploy-script callers. | | `bin/shared-editing-server.sh` | `(cd frontend && npx y-websocket)` | `yarn start` already runs `concurrently --kill-others "npx y-websocket" "ng serve"`. | | `bin/frontend.sh` | `(cd frontend && yarn install && yarn run build)` | Prod build wrapper; only caller was the deleted `build.sh`. | | `bin/python-language-service.sh` | pyright / pylsp launcher | Never referenced — pylsp ships via `bin/pylsp/Dockerfile`'s `ENTRYPOINT ["…","run_pylsp.sh"]`. | | `bin/build-services.sh` | `sbt clean dist` + unzip each service's zip | **Already broken** — `unzip amber/target/universal/texera-*.zip` won't match (now `amber-*`); only callers were `deploy-daemon.sh` + `build.sh` (both in #5971). | Plus a one-line touch to `bin/README.md` to drop the prose mention of `build-services.sh`. `bin/build-images.sh` and `bin/pylsp/run_pylsp.sh` stay — both still have active callers (README and `bin/pylsp/Dockerfile` respectively). ### Any related issues, documentation, discussions? Closes #5972. **Depends on #5971** — the remaining references to these wrappers all live in `deploy-daemon.sh` / `deploy-docker.sh` / `build.sh`, which #5971 removes. Land in that order. ### How was this PR tested? Static — only deletions and a one-line README edit. Confirmed: * `grep -rln` over `*.sh / *.md / *.yml / *.yaml / *.scala / *.py / *.dockerfile / Dockerfile*` returns nothing outside the deleted files themselves once #5971's deletions are applied; * No Dockerfile invokes any of them (per-service Dockerfiles use the dist launcher directly via `CMD ["bin/<service>"]`); * `bin/k8s/**` doesn't reference them; * `bin/local-dev.sh` doesn't shell out to them. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Anthropic, Claude Opus 4.7). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
