Yicong-Huang opened a new pull request, #5971:
URL: https://github.com/apache/texera/pull/5971

   ### What changes were proposed in this PR?
   
   Delete four dead scripts under `bin/`:
   
   | File | What it was | Why dead |
   |---|---|---|
   | `bin/deploy-docker.sh` | Single-container Docker entrypoint that 
backgrounded `server.sh` + `workflow-compiling-service.sh` + 
`workflow-computing-unit.sh` and `wait -n`'d. Added in #2548. | Obsolete since 
texera split into per-service Dockerfiles 
(`bin/texera-web-application.dockerfile`, 
`bin/workflow-compiling-service.dockerfile`, 
`bin/computing-unit-master.dockerfile`, …), each running one 
sbt-native-packager dist launcher via `CMD ["bin/<service>"]`. |
   | `bin/deploy-daemon.sh` | `sbt dist` + Angular prod build + `setsid nohup 
bin/server.sh`. | Replaced by k8s / per-service Dockerfiles for prod and by 
`bin/local-dev.sh` for dev. No caller. |
   | `bin/build.sh` | Wrapper for `build-services.sh + frontend.sh`. | No 
caller. `sbt dist` and `yarn build` are what we actually run. |
   | `bin/frontend-dev.sh` | One-line `(cd frontend && ng serve)`. | No caller; 
`bin/local-dev.sh` starts ng serve directly. |
   
   Verified no remaining references via `grep -rln` over `*.sh / *.md / *.yml / 
*.yaml / *.scala / *.py / *.dockerfile / Dockerfile*` plus `bin/k8s/`. The 
Tier-2 follow-up (the per-service `*.sh` wrappers these scripts called into — 
`server.sh` / `config-service.sh` / `file-service.sh` / 
`workflow-compiling-service.sh` / `workflow-computing-unit.sh` / 
`shared-editing-server.sh` / `frontend.sh` / `build-services.sh`) is a separate 
cleanup — they become orphans here, but I want to handle the per-service 
deletions in a focused PR.
   
   ### Any related issues, documentation, discussions?
   
   Closes #5970.
   
   ### How was this PR tested?
   
   Static — only deletions. Confirmed:
   * `grep -rln` for each script's name across the repo returned nothing 
outside the deleted files themselves;
   * No `bin/<service>.dockerfile` invokes any of them;
   * `bin/k8s/**` doesn't reference them;
   * `bin/README.md` doesn't mention them;
   * `bin/local-dev.sh` doesn't shell out to them (it uses dist launchers 
directly).
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Anthropic, Claude Opus 4.7).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to