amaannawab923 commented on PR #38369:
URL: https://github.com/apache/superset/pull/38369#issuecomment-4004019808
> Hey @amaannawab923 , thank you so much for the work placed into AG-GRID, I
know it's not something easy. While I am looking at the code it feels like it's
getting more complex by the day. Is there something we can do about ag-grid to
make it easier to maintain? I am curious about your opinion and if you have any
recommendations about this for future improvements/refactors.
Thanks @Alex! Appreciate the feedback.
Totally agree , the AG-Grid module has grown in complexity and it's
something I've been thinking about
too and its complex enough. This PR was intentionally scoped to just the
current feature/fix, but I do plan to raise follow-up on Refactoring into
seperate files or modules for Permalinks , Sql Expression conversion & other
touch points which we can refactor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
