sadpandajoe commented on PR #38387:
URL: https://github.com/apache/superset/pull/38387#issuecomment-4002409985
Re: Bito suggestions on `d8577a9`:
**JSON.stringify → join for memo deps (Lines 104-108, 109-113):**
`JSON.stringify` is the safer choice here — it handles edge cases that
`join(",")` would silently coalesce (e.g., `[1,,3].join(",")` behavior with
sparse arrays). The performance difference is negligible for small arrays of
integer IDs.
**"Incorrect test comment" (Line 416):** The comment is accurate. The test
adds terms 0–20 (21 entries). When term20 is inserted, term0 is evicted (FIFO).
Then term0 is re-fetched and re-inserted as the newest entry, which evicts
term1. So term1 is indeed evicted when term0 is re-added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
