eschutho commented on code in PR #38405: URL: https://github.com/apache/superset/pull/38405#discussion_r2886839637
########## superset/mcp_service/chart/viz_type_names.py: ########## @@ -0,0 +1,109 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Mapping of internal viz_type identifiers to user-friendly display names. + +This module provides human-readable chart type names for MCP responses, +preventing internal implementation details from leaking to end users. +The display names match those shown in the Superset UI. +""" + +# Internal viz_type → user-facing display name +VIZ_TYPE_DISPLAY_NAMES: dict[str, str] = { Review Comment: @aminghadersohi each chart's metadata has it's own readable name written there. To avoid duplication and needing to maintain two lists, can we use that instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
