sadpandajoe commented on code in PR #38309:
URL: https://github.com/apache/superset/pull/38309#discussion_r2885514741


##########
UPDATING.md:
##########
@@ -302,9 +225,17 @@ Note: Pillow is now a required dependency (previously 
optional) to support image
 - [31590](https://github.com/apache/superset/pull/31590) Marks the begining of 
intricate work around supporting dynamic Theming, and breaks support for 
[THEME_OVERRIDES](https://github.com/apache/superset/blob/732de4ac7fae88e29b7f123b6cbb2d7cd411b0e4/superset/config.py#L671)
 in favor of a new theming system based on AntD V5. Likely this will be in 
disrepair until settling over the 5.x lifecycle.
 - [32432](https://github.com/apache/superset/pull/31260) Moves the List Roles 
FAB view to the frontend and requires `FAB_ADD_SECURITY_API` to be enabled in 
the configuration and `superset init` to be executed.
 - [34319](https://github.com/apache/superset/pull/34319) Drill to Detail and 
Drill By is now supported in Embedded mode, and also with the `DASHBOARD_RBAC` 
FF. If you don't want to expose these features in Embedded / `DASHBOARD_RBAC`, 
make sure the roles used for Embedded / `DASHBOARD_RBAC`don't have the required 
permissions to perform D2D actions.
+- [#38185](https://github.com/apache/superset/issues/38185) **Embedded SDK / 
Guest Token — independent JWT configuration**: The guest token system uses its 
own JWT configuration keys (`GUEST_TOKEN_JWT_ALGO`, `GUEST_TOKEN_JWT_SECRET`, 
`GUEST_TOKEN_JWT_EXP_SECONDS`) which are **completely independent** of 
Flask-JWT-Extended's `JWT_ALGORITHM` setting. If you configure `JWT_ALGORITHM = 
"RS256"` (or any non-default value) for your login flow, you **must** also 
explicitly set the guest token keys in `superset_config.py` to avoid `403 
Forbidden` errors on the Embedded SDK's `/api/v1/dashboard/{id}/datasets` 
endpoint:

Review Comment:
   should this be in the 6.0 section?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to