kasiazjc commented on PR #37298: URL: https://github.com/apache/superset/pull/37298#issuecomment-3877724016
> > @kasiazjc Just one last comment. If you look at [this](https://github.com/apache/superset/issues/36412), there's a need for these global banners. We can design them: > > > > * Per module like you did on the screenshot above, which means that depending on the module it will be placed differently. For example, the location of the banner in SQL Lab might be different than the homepage or Explore. > > * We can design them globally like a banner that appears below the header and takes the full width or a floating banner on the center that does not compete with the page elements. > > > > WDYT? > > Yeah I think the second option makes more sense, especially from an admin setup perspective. If we're talking about app-level announcements, warnings, or errors that admins need to configure, having a consistent global placement (full-width below header I think would work best) is way easier to manage than trying to figure out module-specific positioning for each message (also would be a pain to implement especially before full app pluginisation :D). > > The module-level banners we designed for SQL Lab still make sense for workflow-specific validation and errors, but for admin-managed messaging, the global approach is cleaner both for setup and for users. So this is what I would go with for now. @michael-s-molina for now - added a note on error types and the mockup I pasted above in our [figma file ](https://www.figma.com/design/wdmjjKiCBgPMFEM3Ua7WIi/SQL-Lab-as-Plugins?node-id=3112-4209&t=SwBXGDVrIPT5esqu-1) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
