villebro commented on PR #36368:
URL: https://github.com/apache/superset/pull/36368#issuecomment-3865026920
Thanks for the re-review @michael-s-molina ! Please check the latest commit
with the following changes (these should address the issues you raised + some
other improvements):
- task signatures, including API routes, have been simplified to be UUID
only. Also the `Task` model was updated to use native UUID instead of having a
string based type (slightly improved efficiency and performance)
- A few lingering `datetime.now(timezone.utc)` fixes
- Fixed all remaining instances of `if TYPE_CHECKING: pass` (there were
unrelated ones, too, so I fixed them also)
- Updated '/api/v1/task/{task_uuid}/status' endpoint to do a targeted select
on the `status` column only to avoid pulling in the entire task object
- Removed a few redundant endpoints that were pulled in by
`RouteMethod.REST_MODEL_VIEW_CRUD_SET` (I noticed these when checking Swagger
UI)
- Added non-unique index to `task_key`
- Made tasks load subscribers eagerly to avoid N=1 queries when listing tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
