bito-code-review[bot] commented on code in PR #37709:
URL: https://github.com/apache/superset/pull/37709#discussion_r2777545865
##########
superset-frontend/src/components/MessageToasts/ToastPresenter.tsx:
##########
@@ -33,17 +33,72 @@ const StyledToastPresenter = styled.div<VisualProps>(
${position === 'bottom' ? 'bottom' : 'top'}: 0px;
right: 0px;
margin-right: 50px;
- margin-bottom: 50px;
+ margin-block: 50px;
z-index: ${theme.zIndexPopupBase + 1};
word-break: break-word;
+ height: calc(100vh - 100px);
+
+ display: flex;
+ flex-direction: ${position === 'bottom' ? 'column-reverse' : 'column'};
+ align-items: stretch;
+ gap: ${theme.sizeUnit * 2}px;
+ overflow-y: auto;
+ overscroll-behavior: contain;
+ overflow-x: hidden;
+ scrollbar-width: thin;
+
+ scrollbar-color:
+ color-mix(in srgb, ${theme.colorText}, transparent 75%)
+ transparent;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Invalid CSS color-mix syntax</b></div>
<div id="fix">
The color-mix function syntax is invalid here because it omits the
percentage for the first color and uses percentages that exceed 100%, which per
CSS spec clamps to 50/50 mix instead of the intended transparency. This affects
scrollbar thumb colors in Firefox, potentially making them appear differently
than expected.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- scrollbar-color:
- color-mix(in srgb, ${theme.colorText}, transparent 75%)
- transparent;
+ scrollbar-color:
+ color-mix(in srgb, ${theme.colorText} 25%, transparent 75%)
+ transparent;
@@ -58,3 +58,3 @@
- scrollbar-color:
- color-mix(in srgb, ${theme.colorText}, transparent 60%)
- transparent;
+ scrollbar-color:
+ color-mix(in srgb, ${theme.colorText} 40%, transparent 60%)
+ transparent;
@@ -73,5 +73,5 @@
- background-color: color-mix(
- in srgb,
- ${theme.colorText},
- transparent 75%
- );
+ background-color: color-mix(
+ in srgb,
+ ${theme.colorText} 25%,
+ transparent 75%
+ );
@@ -85,5 +85,5 @@
- background-color: color-mix(
- in srgb,
- ${theme.colorText},
- transparent 60%
- );
+ background-color: color-mix(
+ in srgb,
+ ${theme.colorText} 40%,
+ transparent 60%
+ );
```
</div>
</details>
</div>
<small><i>Code Review Run #473b21</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
