rusackas opened a new pull request, #37768: URL: https://github.com/apache/superset/pull/37768
## SUMMARY Following up on [PR #37591](https://github.com/apache/superset/pull/37591) which consolidated `ColorSchemeEnum`, this PR addresses additional type consolidation opportunities identified in the codebase. ### Changes **1. Shared Table Types Consolidation** Moved duplicate type definitions from `plugin-chart-table` and `plugin-chart-ag-grid-table` to `@superset-ui/chart-controls`: | Type | Previous Location | New Location | |------|-------------------|--------------| | `BasicColorFormatterType` | Both table plugins | `@superset-ui/chart-controls` | | `SortByItem` | Both table plugins | `@superset-ui/chart-controls` | | `SearchOption` | Both table plugins | `@superset-ui/chart-controls` | | `ServerPaginationData` | Both table plugins | `@superset-ui/chart-controls` | | `TableColumnConfig` | Both table plugins | `@superset-ui/chart-controls` | | `DataColumnMeta` | Both table plugins | `@superset-ui/chart-controls` | | `CustomFormatter` | Both table plugins | `@superset-ui/chart-controls` | Both table plugins now import from `@superset-ui/chart-controls` and re-export for backwards compatibility. **2. Funnel Label Type Typo Fix** - Renamed `EchartsFunnelLabelTypeType` → `EchartsFunnelLabelType` (removed duplicate "Type" suffix) - Updated all references in `types.ts`, `transformProps.ts`, and `controlPanel.tsx` ### Note on ECharts Label Enums After investigation, the different ECharts label type enums (Pie, Funnel, Treemap, Sunburst, Radar) are intentionally different subsets for each chart type. Consolidating them would reduce type safety. The main issue was the Funnel typo which is now fixed. ## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A - No UI changes ## TESTING INSTRUCTIONS 1. Build the frontend: `npm run build` 2. Run type checks: `npm run type` 3. Run tests for affected plugins: - `npm test -- --testPathPatterns="plugin-chart-table"` - `npm test -- --testPathPatterns="plugin-chart-ag-grid-table"` - `npm test -- --testPathPatterns="Funnel"` ## ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.ai/code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
