michael-s-molina opened a new pull request, #37760: URL: https://github.com/apache/superset/pull/37760
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This PR includes several SQL Lab improvements and bug fixes: #### Bug Fixes - **Fix Save Query/Save Dataset buttons not appearing on initial load** - The `allows_virtual_table_explore` property was missing from the SQL Lab bootstrap API response - Added the property to `bootstrap_sqllab_data()` in `superset/sqllab/utils.py` - This property controls whether the Save Query and Save Dataset buttons are shown - **Fix "Run selection" not working** - The `onReady` callback in `AceEditorProvider` was being called in a `useEffect` that ran before the editor was actually loaded - Moved the `onReady` call inside `onEditorLoad` callback so it fires after the editor is properly initialized - This ensures the editor handle is available for selection detection #### UI Improvements - **Change pin table icon to pushpin** - Replaced `FolderAddOutlined` with `PushpinOutlined` icon for the "Pin to result panel" action - Added `PushpinOutlined` to the available Ant Design icons in `AntdEnhanced.tsx` - **Adjust left sidebar toolbar alignment** - Added negative margin to align toolbar icons with other elements on the screen - Added margin-bottom to the search bar for better spacing - **Reduce toolbar icon gap** - Reduced gap between toolbar icons from `theme.sizeUnit * 2` to `theme.sizeUnit` in `PanelToolbar` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <img width="460" height="99" alt="Screenshot 2026-02-06 at 15 22 07" src="https://github.com/user-attachments/assets/356e65f1-206f-4866-a79e-2f64b0193f63"; /> <img width="396" height="233" alt="Screenshot 2026-02-06 at 15 48 01" src="https://github.com/user-attachments/assets/fd2c021a-0218-4660-a012-5512f0b13678"; /> ### TESTING INSTRUCTIONS - Open SQL Lab and verify Save Query/Save Dataset buttons appear immediately (without needing to open the database selector) - Select text in the SQL editor and verify the Run button changes to "Run selection" - Verify the pushpin icon appears for the "Pin to result panel" action - Verify toolbar alignment in the left sidebar looks correct ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
