rusackas commented on PR #37441:
URL: https://github.com/apache/superset/pull/37441#issuecomment-3861791313
## timezone-mock 1.4.0 Test Failures
This dependency update is failing due to behavior changes in timezone-mock
1.4.0 that affect date calculations in timezone-aware tests.
### Failures:
1. **parseDttmToDate.test.ts** - "today" calculation is off by 1 day
- Expected: `2024-06-03T00:00:00.000Z`
- Received: `2024-06-02T00:00:00.000Z`
2. **getTimeOffset.test.ts** - Relative date calculation is off by 1 day
- Expected: `4 days ago`
- Received: `5 days ago`
### Analysis:
The timezone-mock library has changed its behavior in how it handles date
boundaries across timezones. The test failures are consistent (all off by
exactly 1 day), suggesting a systematic change in how the library computes
dates at timezone boundaries.
### Required Work:
1. Investigate the timezone-mock 1.4.0 changelog/commits to understand the
behavior change
2. Determine if the new behavior is correct or if the old behavior was
correct
3. Update test expectations in both test files if the new behavior is correct
4. Consider whether this behavior change affects production code (not just
tests)
This requires manual investigation to ensure we're handling timezone
calculations correctly in the application.
Labeled as `dependencies:needs-work` for manual attention.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
