rusackas commented on PR #34742: URL: https://github.com/apache/superset/pull/34742#issuecomment-3857291707
Thanks for the review feedback! I've addressed both suggestions in the latest commit: 1. **Removed the redundant `|| 0.001` fallback** - You're correct that `Math.pow(10, -Math.min(decimalPlaces + 1, 6))` can never return a falsy value. The minimum value would be `1e-7` (when decimalPlaces is 6+), which is still truthy. 2. **Changed `Math.ceil` to `Math.round`** - This provides more balanced step sizes. For example, if the ideal step is 3.2 and the magnitude is 1, `Math.ceil` would give 4 while `Math.round` gives 3, which is closer to the target of ~100 steps across the range. The branch has also been rebased on latest master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
